1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
|
package eduvpn_verify
import (
"bufio"
"errors"
"fmt"
"io/ioutil"
"os"
"strconv"
"testing"
)
const (
ok = -1
errAny = -2
)
func compareResults(t *testing.T, ret bool, err error, expected int, call func() string) {
getCode := func(err error) int {
switch e := err.(type) {
case detailedVerifyError:
return int(e.Code)
case VerifyError:
return int(e.Code)
}
panic(nil)
}
if (err == nil) != (expected == ok) || err != nil && expected != errAny && getCode(err) != expected {
var errMsg string
if err != nil {
errMsg = fmt.Sprintf("%v %v (cause %v)", getCode(err), err, errors.Unwrap(err))
} else {
errMsg = "<ok>"
}
var wantErrCode string
switch expected {
case ok:
wantErrCode = "<ok>"
case errAny:
wantErrCode = "<any>"
default:
wantErrCode = strconv.Itoa(expected)
}
t.Errorf("%v\nerror = %v, wantErr %v", call(), errMsg, wantErrCode)
return
}
if ret != (expected == ok) {
t.Errorf("%v\n= %v, want %v", call(), ret, expected == ok)
}
}
func Test_verifyWithKeys(t *testing.T) {
var err error
var pk []string
{
file, err := os.Open("test_data/dummy/public.key")
if err != nil {
panic(err)
}
defer file.Close()
scanner := bufio.NewScanner(file)
for i := 0; i < 2; i++ {
if !scanner.Scan() {
panic(scanner.Err())
}
}
pk = []string{scanner.Text()}
}
tests := []struct {
result detailedVerifyErrorCode
testName string
signatureFile string
jsonFile string
expectedFileName string
minSignTime uint64
allowedPks []string
}{
{errInvalidSignatureAlgorithm, "pure", "server_list.json.pure.minisig", "server_list.json", "server_list.json", 10, pk},
{ok, "valid server_list", "server_list.json.minisig", "server_list.json", "server_list.json", 10, pk},
{ok, "TC no hashed", "server_list.json.tc_nohashed.minisig", "server_list.json", "server_list.json", 10, pk},
{ok, "TC later time", "server_list.json.tc_latertime.minisig", "server_list.json", "server_list.json", 10, pk},
{errWrongFileName, "server_list TC file:organization_list", "server_list.json.tc_orglist.minisig", "server_list.json", "server_list.json", 10, pk},
{errWrongFileName, "organization_list as server_list", "organization_list.json.minisig", "organization_list.json", "server_list.json", 10, pk},
{errWrongFileName, "TC file:otherfile", "server_list.json.tc_otherfile.minisig", "server_list.json", "server_list.json", 10, pk},
{errInvalidTrustedComment, "TC no file", "server_list.json.tc_nofile.minisig", "server_list.json", "server_list.json", 10, pk},
{errInvalidTrustedComment, "TC no time", "server_list.json.tc_notime.minisig", "server_list.json", "server_list.json", 10, pk},
{errAny, "TC empty time", "server_list.json.tc_emptytime.minisig", "server_list.json", "server_list.json", 10, pk},
{errAny, "TC empty file", "server_list.json.tc_emptyfile.minisig", "server_list.json", "server_list.json", 10, pk},
{errInvalidTrustedComment, "TC random", "server_list.json.tc_random.minisig", "server_list.json", "server_list.json", 10, pk},
{ok, "large time", "server_list.json.large_time.minisig", "server_list.json", "server_list.json", 43e8, pk},
{ok, "lower min time", "server_list.json.minisig", "server_list.json", "server_list.json", 5, pk},
{errTooOld, "higher min time", "server_list.json.minisig", "server_list.json", "server_list.json", 11, pk},
{ok, "valid organization_list", "organization_list.json.minisig", "organization_list.json", "organization_list.json", 10, pk},
{errWrongFileName, "organization_list TC file:server_list", "organization_list.json.tc_servlist.minisig", "organization_list.json", "organization_list.json", 10, pk},
{errWrongFileName, "server_list as organization_list", "server_list.json.minisig", "server_list.json", "organization_list.json", 10, pk},
{errUnknownExpectedFileName, "valid other_list", "other_list.json.minisig", "other_list.json", "other_list.json", 10, pk},
{errWrongFileName, "other_list as server_list", "other_list.json.minisig", "other_list.json", "server_list.json", 10, pk},
{errInvalidSignatureFormat, "invalid signature file", "random.txt", "server_list.json", "server_list.json", 10, pk},
{errInvalidSignatureFormat, "empty signature file", "empty", "server_list.json", "server_list.json", 10, pk},
{errWrongKey, "wrong key", "server_list.json.wrong_key.minisig", "server_list.json", "server_list.json", 10, pk},
{errInvalidSignatureAlgorithm, "forged pure signature", "server_list.json.forged_pure.minisig", "server_list.json.blake2b", "server_list.json", 10, pk},
{errInvalidSignature, "forged key ID", "server_list.json.forged_keyid.minisig", "server_list.json", "server_list.json", 10, pk},
{errWrongKey, "no allowed keys", "server_list.json.minisig", "server_list.json", "server_list.json", 10, []string{}},
{ok, "multiple allowed keys 1", "server_list.json.minisig", "server_list.json", "server_list.json", 10, []string{
pk[0], "RWSf0PYToIUJmDlsz21YOXvgQzHj9NSdyJUqEY5ZdfS9GepeXt3+JJRZ",
}},
{ok, "multiple allowed keys 2", "server_list.json.minisig", "server_list.json", "server_list.json", 10, []string{
"RWSf0PYToIUJmDlsz21YOXvgQzHj9NSdyJUqEY5ZdfS9GepeXt3+JJRZ", pk[0],
}},
{errInvalidPublicKey, "invalid allowed key", "server_list.json.minisig", "server_list.json", "server_list.json", 10, []string{"AAA"}},
}
files := map[string][]byte{}
for _, test := range tests {
signature, loaded := files[test.signatureFile]
if !loaded {
signature, err = ioutil.ReadFile("test_data/dummy/" + test.signatureFile)
if err != nil {
panic(err)
}
files[test.signatureFile] = signature
}
json, loaded := files[test.jsonFile]
if !loaded {
json, err = ioutil.ReadFile("test_data/dummy/" + test.jsonFile)
if err != nil {
panic(err)
}
files[test.jsonFile] = json
}
}
for _, tt := range tests {
tt := tt
t.Run(tt.testName, func(t *testing.T) {
t.Parallel()
valid, err := verifyWithKeys(string(files[tt.signatureFile]), files[tt.jsonFile],
tt.expectedFileName, tt.minSignTime, tt.allowedPks)
compareResults(t, valid, err, int(tt.result), func() string {
return fmt.Sprintf("verifyWithKeys(%q, %q, %q, %v, %v)",
tt.signatureFile, tt.jsonFile, tt.expectedFileName, tt.minSignTime, tt.allowedPks)
})
})
}
}
func Test_Verify(t *testing.T) {
var err error
tests := []struct {
result VerifyErrorCode
testName string
signatureFile string
jsonFile string
expectedFileName string
minSignTime uint64
}{
//TODO tests with real valid *prehashed* signatures
{ErrInvalidSignature, "pure server_list", "server_list-1.json.pure.minisig", "server_list-1.json", "server_list.json", 1636532223},
{ErrInvalidSignature, "pure organization_list", "organization_list-1.json.pure.minisig", "organization_list-1.json", "organization_list.json", 1636532223},
{ErrInvalidSignatureUnknownKey, "wrong key", "../dummy/server_list.json.minisig", "../dummy/server_list.json", "server_list.json", 10},
}
files := map[string][]byte{}
for _, test := range tests {
signature, loaded := files[test.signatureFile]
if !loaded {
signature, err = ioutil.ReadFile("test_data/real/" + test.signatureFile)
if err != nil {
panic(err)
}
files[test.signatureFile] = signature
}
json, loaded := files[test.jsonFile]
if !loaded {
json, err = ioutil.ReadFile("test_data/real/" + test.jsonFile)
if err != nil {
panic(err)
}
files[test.jsonFile] = json
}
}
for _, tt := range tests {
tt := tt
t.Run(tt.testName, func(t *testing.T) {
t.Parallel()
valid, err := Verify(string(files[tt.signatureFile]), files[tt.jsonFile], tt.expectedFileName, tt.minSignTime)
compareResults(t, valid, err, int(tt.result), func() string {
return fmt.Sprintf("Verify(%q, %q, %q, %v)",
tt.signatureFile, tt.jsonFile, tt.expectedFileName, tt.minSignTime)
})
})
}
}
|
