1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
|
package client
import (
"context"
"fmt"
"os"
"os/exec"
"strconv"
"strings"
"testing"
"time"
httpw "github.com/eduvpn/eduvpn-common/internal/http"
"github.com/eduvpn/eduvpn-common/types/cookie"
"github.com/eduvpn/eduvpn-common/types/protocol"
srvtypes "github.com/eduvpn/eduvpn-common/types/server"
)
func getServerURI(t *testing.T) string {
serverURI := os.Getenv("SERVER_URI")
if serverURI == "" {
t.Skip("Skipping server test as no SERVER_URI env var has been passed")
}
serverURI, parseErr := httpw.EnsureValidURL(serverURI, true)
if parseErr != nil {
t.Skip("Skipping server test as the server uri is not valid")
}
return serverURI
}
func runCommand(errBuffer *strings.Builder, name string, args ...string) error {
cmd := exec.Command(name, args...)
cmd.Stderr = errBuffer
err := cmd.Start()
if err != nil {
return err
}
return cmd.Wait()
}
func loginOAuthSelenium(ck *cookie.Cookie, url string) {
// We could use the go selenium library
// But it does not support the latest selenium v4 just yet
var errBuffer strings.Builder
err := runCommand(&errBuffer, "python3", "../selenium_eduvpn.py", url)
if err != nil {
_ = ck.Cancel()
panic(fmt.Sprintf(
"Login OAuth with selenium script failed with error %v and stderr %s",
err,
errBuffer.String(),
))
}
}
func stateCallback(
t *testing.T,
ck *cookie.Cookie,
_ FSMStateID,
newState FSMStateID,
data interface{},
) {
if newState == StateOAuthStarted {
url, ok := data.(string)
if !ok {
t.Fatalf("data is not a string for OAuth URL")
}
loginOAuthSelenium(ck, url)
}
}
func TestServer(t *testing.T) {
serverURI := getServerURI(t)
ck := cookie.NewWithContext(context.Background())
defer ck.Cancel() //nolint:errcheck
dir := t.TempDir()
state, err := New(
"org.letsconnect-vpn.app.linux",
"0.1.0-test",
dir,
func(old FSMStateID, new FSMStateID, data interface{}) bool {
stateCallback(t, &ck, old, new, data)
return true
},
false,
)
if err != nil {
t.Fatalf("Creating client error: %v", err)
}
err = state.Register()
if err != nil {
t.Fatalf("Registering error: %v", err)
}
addErr := state.AddServer(&ck, serverURI, srvtypes.TypeCustom, false)
if addErr != nil {
t.Fatalf("Add error: %v", addErr)
}
_, configErr := state.GetConfig(&ck, serverURI, srvtypes.TypeCustom, false, false)
if configErr != nil {
t.Fatalf("Connect error: %v", configErr)
}
}
func TestTokenExpired(t *testing.T) {
serverURI := getServerURI(t)
expiredTTL := os.Getenv("OAUTH_EXPIRED_TTL")
if expiredTTL == "" {
t.Log(
"No expired TTL present, skipping this test. Set OAUTH_EXPIRED_TTL env variable to run this test",
)
return
}
// Convert the env variable to an int and signal error if it is not possible
expiredInt, expiredErr := strconv.Atoi(expiredTTL)
if expiredErr != nil {
t.Fatalf("Cannot convert EXPIRED_TTL env variable to an int with error %v", expiredErr)
}
// Get a vpn state
ck := cookie.NewWithContext(context.Background())
defer ck.Cancel() //nolint:errcheck
dir := t.TempDir()
state, err := New(
"org.letsconnect-vpn.app.linux",
"0.1.0-test",
dir,
func(old FSMStateID, new FSMStateID, data interface{}) bool {
stateCallback(t, &ck, old, new, data)
return true
},
false,
)
if err != nil {
t.Fatalf("Creating client error: %v", err)
}
err = state.Register()
if err != nil {
t.Fatalf("Registering error: %v", err)
}
addErr := state.AddServer(&ck, serverURI, srvtypes.TypeCustom, false)
if addErr != nil {
t.Fatalf("Add error: %v", addErr)
}
_, configErr := state.GetConfig(&ck, serverURI, srvtypes.TypeCustom, false, false)
if configErr != nil {
t.Fatalf("Connect error before expired: %v", configErr)
}
currentServer, serverErr := state.Servers.Current()
if serverErr != nil {
t.Fatalf("No server found")
}
serverOAuth := currentServer.OAuth()
accessToken, accessTokenErr := serverOAuth.AccessToken(ck.Context())
if accessTokenErr != nil {
t.Fatalf("Failed to get token: %v", accessTokenErr)
}
// Wait for TTL so that the tokens expire
time.Sleep(time.Duration(expiredInt) * time.Second)
_, configErr = state.GetConfig(&ck, serverURI, srvtypes.TypeCustom, false, false)
if configErr != nil {
t.Fatalf("Connect error after expiry: %v", configErr)
}
// Check if tokens have changed
accessTokenAfter, accessTokenAfterErr := serverOAuth.AccessToken(ck.Context())
if accessTokenAfterErr != nil {
t.Fatalf("Failed to get token: %v", accessTokenAfterErr)
}
if accessToken == accessTokenAfter {
t.Errorf("Access token is the same after refresh")
}
}
// Test if an invalid profile will be corrected.
func TestInvalidProfileCorrected(t *testing.T) {
dir := t.TempDir()
serverURI := getServerURI(t)
ck := cookie.NewWithContext(context.Background())
defer ck.Cancel() //nolint:errcheck
state, err := New(
"org.letsconnect-vpn.app.linux",
"0.1.0-test",
dir,
func(old FSMStateID, new FSMStateID, data interface{}) bool {
stateCallback(t, &ck, old, new, data)
return true
},
false,
)
if err != nil {
t.Fatalf("Creating client error: %v", err)
}
err = state.Register()
if err != nil {
t.Fatalf("Registering error: %v", err)
}
addErr := state.AddServer(&ck, serverURI, srvtypes.TypeCustom, false)
if addErr != nil {
t.Fatalf("Add error: %v", addErr)
}
_, configErr := state.GetConfig(&ck, serverURI, srvtypes.TypeCustom, false, false)
if configErr != nil {
t.Fatalf("First connect error: %v", configErr)
}
currentServer, serverErr := state.Servers.Current()
if serverErr != nil {
t.Fatalf("No server found")
}
base, baseErr := currentServer.Base()
if baseErr != nil {
t.Fatalf("No base found")
}
previousProfile := base.Profiles.Current
base.Profiles.Current = "IDONOTEXIST"
_, configErr = state.GetConfig(&ck, serverURI, srvtypes.TypeCustom, false, false)
if configErr != nil {
t.Fatalf("Second connect error: %v", configErr)
}
if base.Profiles.Current != previousProfile {
t.Fatalf(
"Profiles do no match: current %s and previous %s",
base.Profiles.Current,
previousProfile,
)
}
}
// TestConfigStartup tests if the 'startup' variable for getconfig behaves as expected
func TestConfigStartup(t *testing.T) {
serverURI := getServerURI(t)
ck := cookie.NewWithContext(context.Background())
defer ck.Cancel() //nolint:errcheck
dir := t.TempDir()
state, err := New(
"org.letsconnect-vpn.app.linux",
"0.1.0-test",
dir,
func(old FSMStateID, new FSMStateID, data interface{}) bool {
stateCallback(t, &ck, old, new, data)
return true
},
false,
)
if err != nil {
t.Fatalf("Creating client error: %v", err)
}
err = state.Register()
if err != nil {
t.Fatalf("Failed to register with error: %v", err)
}
// we set true as last argument here such that no callbacks are ran
err = state.AddServer(&ck, serverURI, srvtypes.TypeCustom, true)
if err != nil {
t.Fatalf("Failed to add server for trying config startup: %v", err)
}
testTrue := func() {
// Now get config with setting startup to true
startup := true
_, err := state.GetConfig(&ck, serverURI, srvtypes.TypeCustom, false, startup)
// this should fail as we have not authorized yet/chosen profile and startup=true does not do these callbacks
if err == nil {
t.Fatal("Got no error after getting config with startup true")
}
if !strings.HasPrefix(err.Error(), "The client tried to autoconnect to the VPN server") {
t.Fatalf("GetConfig error for GetConfig with startup=true is not what we expect: %v", err)
}
}
testFalse := func() {
startup := false
// This should succeed
_, err := state.GetConfig(&ck, serverURI, srvtypes.TypeCustom, false, startup)
// this should fail as we have not authorized yet/chosen profile
if err != nil {
t.Fatalf("Got error after getting config with startup=false: %v", err)
}
}
testTrue()
testFalse()
// set invalid authorization and test again
// we cannot test by setting invalid profile because the server only has 1 profile
// TODO: support multiple profiles in the test server
state.Servers.CustomServers.Map[serverURI].OAuth().SetTokenRenew()
testTrue()
testFalse()
}
// Test if prefer tcp is handled correctly by checking the returned config and config type.
func TestPreferTCP(t *testing.T) {
serverURI := getServerURI(t)
ck := cookie.NewWithContext(context.Background())
defer ck.Cancel() //nolint:errcheck
dir := t.TempDir()
state, err := New(
"org.letsconnect-vpn.app.linux",
"0.1.0-test",
dir,
func(old FSMStateID, new FSMStateID, data interface{}) bool {
stateCallback(t, &ck, old, new, data)
return true
},
false,
)
if err != nil {
t.Fatalf("Creating client error: %v", err)
}
err = state.Register()
if err != nil {
t.Fatalf("Registering error: %v", err)
}
addErr := state.AddServer(&ck, serverURI, srvtypes.TypeCustom, false)
if addErr != nil {
t.Fatalf("Add error: %v", addErr)
}
// get a config with preferTCP set to true
config, configErr := state.GetConfig(&ck, serverURI, srvtypes.TypeCustom, true, false)
// Test server should accept prefer TCP!
if config.Protocol != protocol.OpenVPN {
t.Fatalf("Invalid protocol for prefer TCP, got: WireGuard, want: OpenVPN")
}
if configErr != nil {
t.Fatalf("Config error: %v", configErr)
}
// We also test for script security 0 here
if !strings.HasSuffix(config.VPNConfig, "udp\nscript-security 0") {
t.Fatalf("Suffix for prefer TCP is not in the right order for config: %s", config.VPNConfig)
}
// get a config with preferTCP set to false
config, configErr = state.GetConfig(&ck, serverURI, srvtypes.TypeCustom, false, false)
if configErr != nil {
t.Fatalf("Config error: %v", configErr)
}
// We also test for script security 0 here
if config.Protocol == protocol.OpenVPN &&
!strings.HasSuffix(config.VPNConfig, "tcp\nscript-security 0") {
t.Fatalf("Suffix for disable prefer TCP is not in the right order for config: %s", config.VPNConfig)
}
}
func TestInvalidClientID(t *testing.T) {
tests := map[string]bool{
"test": false,
"org.letsconnect-vpn.app.linux": true,
"org.letsconnect-vpn": false,
"org.letsconnect-vpn.app": false,
"org.letsconnect-vpn.linuxsd": false,
"org.letsconnect-vpn.app.macos": true,
}
dir := t.TempDir()
for k, v := range tests {
_, err := New(
k,
"0.1.0-test",
dir,
func(old FSMStateID, new FSMStateID, data interface{}) bool {
return true
},
false,
)
if v {
if err != nil {
t.Fatalf("expected valid register with clientID: %v, got error: %v", k, err)
}
continue
}
if err == nil {
t.Fatalf("expected invalid register with clientID: %v, but got no error", k)
}
if !strings.HasPrefix(err.Error(), "The client registered with an invalid client ID") {
t.Fatalf("register error has invalid prefix: %v", err.Error())
}
}
}
|