summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjwijenbergh <jeroenwijenbergh@protonmail.com>2022-10-13 15:40:09 +0200
committerjwijenbergh <jeroenwijenbergh@protonmail.com>2022-10-13 15:42:27 +0200
commite26dd96631022974223f0f4fba48dc95e036d63d (patch)
treea18e45d99ff15df5ec5bd4653ebb314bfbda9f37
parent5f91c97c19741e94550364bdd3b53e80e228a158 (diff)
OAuth: Add a TODO note about ISS
-rw-r--r--internal/oauth/oauth.go5
1 files changed, 5 insertions, 0 deletions
diff --git a/internal/oauth/oauth.go b/internal/oauth/oauth.go
index 6fd7481..c4e3672 100644
--- a/internal/oauth/oauth.go
+++ b/internal/oauth/oauth.go
@@ -289,6 +289,11 @@ func writeResponseHTML(w http.ResponseWriter, title string, message string) erro
//// The callback to retrieve the authorization code: https://datatracker.ietf.org/doc/html/draft-ietf-oauth-v2-1-04#section-1.3.1
func (oauth *OAuth) Callback(w http.ResponseWriter, req *http.Request) {
errorMessage := "failed callback to retrieve the authorization code"
+
+ // TODO: Support iss when servers have properly implemented it
+ // See: https://todo.sr.ht/~eduvpn/server/91
+ // And (rfc): https://www.rfc-editor.org/rfc/rfc9207.html
+
// Extract the authorization code
code, success := req.URL.Query()["code"]
// Shutdown after we're done